Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customized views when publishing the Config #243

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Allow customized views when publishing the Config #243

merged 1 commit into from
Jul 5, 2020

Conversation

paulbalandan
Copy link
Contributor

When we publish Config\Auth for our tinkering, I've noticed that the referenced view files are still the default ones assuming we also published the Views. This PR attempts to address that.

MGatner
MGatner approved these changes Jul 4, 2020
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a good idea, and I like your implementation.

@lonnieezell
Copy link
Owner

Nice, thank you!

@lonnieezell lonnieezell merged commit 5988807 into lonnieezell:develop Jul 5, 2020
@paulbalandan paulbalandan deleted the publish-config-with-views branch July 5, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @lonnieezell @MGatner