Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie changes #232

Merged
merged 2 commits into from
May 26, 2020
Merged

Cookie changes #232

merged 2 commits into from
May 26, 2020

Conversation

nControl88
Copy link
Contributor

  • Added $appConfig->cookieSecure and $appConfig->cookieHTTPOnly
  • Remove cookie after logout

@nControl88
Cookie changes
d912ccc 
- Added $appConfig->cookieSecure and $appConfig->cookieHTTPOnly
- Remove cookie after logout
lonnieezell
lonnieezell requested changes May 26, 2020
View reviewed changes
Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. A couple of small comments on it. Also, I believe there are some tests this needs to be included in.

@nControl88
Copy link
Contributor Author

nControl88 commented May 26, 2020 •
edited
Loading

Thanks for that. I have made the requested changes. Unfortunately I cannot validate or change the tests at the moment.

@lonnieezell lonnieezell merged commit 3da836b into lonnieezell:develop May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nControl88 @lonnieezell