Missing invalidPassword key in language files #162
Conversation
src/Controllers/AuthController.php
Outdated
| @@ -98,6 +98,11 @@ public function attemptLogin() | |||
| $redirectURL = session('redirect_url') ?? '/'; | |||
| unset($_SESSION['redirect_url']); | |||
|
|
|||
| if($redirectURL == site_url('logout')) | |||
There was a problem hiding this comment.
Typically - a pull request should be limited to a single change type. Like the translation strings. Including this only confuses things and makes it more difficult for me to approve.
What's up with this change? I'm not convinced it's a good change and, even it was it has a couple of problems:
- should use
route_toinstead ofsite_urlto account for people changing the logout url. - We have no way of knowing that
/is a good place to send someone to.
The biggest problem I have is that this covers up a potential developer mistake and hides a strange redirection they didn't ask for in our library's controller.
Please remove this change from the PR and I can accept the others.
There was a problem hiding this comment.
Sorry about the confusion, its removed. Will create a separate for other change, if required.
it was not intended to be in the PR, The reason behind that Change was after hitting the logout url the redirect_url on login page is set to logout, so we are stuck in a loop because login page has redirect_url to logout and logout redirect to login again.
No description provided.