Enable FCDB #417
Merged
Enable FCDB #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the md5sum function from the fcdb environment because it created link issues, and md5sum is an insecure hash to begin with. See longturn#287.
QCoreApplication::exit does not work from outside an event loop, and there are other initialization errors than the socket not being initialized correctly. Make sure the server exits immediately in such cases.
Issues missed in some QString migration.
Prior to this patch the file name was empty, and the error message was simply "file not found: ".
The "require" function allows loading external modules, which is the best way of supporting multiple database backends. See longturn#287.
If people want to use it, they can install it from their distribution's repositories. See longturn#287.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Jul 19, 2021
A specific version of Lua used to be required, but this is no longer the case (I think after commit 5aae933/PR longturn#417). Use the version of Lua provided by the system, requiring at least and prioritizing the widely available Lua 5.3. This should fix longturn#504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the use of external Lua packages from
database.lua. It removes the built-in support forluasqlsince it can now be used withrequire "luasql.something"if installed.Since FCDB no longer requires additional dependencies, there is no point in making it optional. It is always enabled.
Closes #287.