chatline: Split creation of unit links from tile/city links #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by clangd.
Splits the functionality to create unit links for the chatline from the functionality to create tile/city links. This allows the user to create a tile link for a tile, even if it is occupied by a unit. | Shortcut | Old behavior | New behavior | | ------------------ | ------------------------------ | ------------------------------ | | Ctrl-Alt-RMB | Link to (unit -> city -> tile) | Link to (city ->tile) | | Ctrl-Alt-Shift-RMB | ./. | Link to (unit -> city -> tile) | It is possible to restore the old behavior by rebinding the shortcuts. No documentation changes are required, as this matches the existing chatline documentation in `data/helpdata.txt`.
blabber
force-pushed
the
bugfix/unit_links
branch
from
fd19297 to
b0e07d3
Compare
jwrober
requested changes
Feb 11, 2025
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the functionality to create unit links for the chatline from the functionality to create tile/city links. This allows the user to create a tile link for a tile, even if it is occupied by a unit.
It is possible to restore the old behavior by rebinding the shortcuts.
No documentation changes are required, as this matches the existing chatline documentation in
data/helpdata.txt.Closes #2524