Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for using featured text links in Lua #2506

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Added support for using featured text links in Lua #2506

merged 1 commit into from
Jan 19, 2025

Conversation

XHawk87
Copy link
Collaborator

@XHawk87 XHawk87 commented Jan 17, 2025

Closes #2473

@jwrober
Copy link
Collaborator

jwrober commented Jan 18, 2025

Code looks ok to me. How does one test this?

@XHawk87
Copy link
Collaborator Author

XHawk87 commented Jan 18, 2025

I tested it using lua commands on the console. Something like...

lua cmd notify.all("%s is the first city", find.city(nil, 0):tile_link_text())

@jwrober jwrober self-requested a review January 19, 2025 20:15
@jwrober jwrober merged commit 73117ba into longturn:master Jan 19, 2025
22 checks passed
@XHawk87 XHawk87 added the back-port back-port candidate label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees

@lmoureaux lmoureaux

Labels
back-port back-port candidate
Projects
Back-port
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lua: Support notifications with featured text
3 participants
@XHawk87 @jwrober @lmoureaux