Fix a crash in the units view #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Units view (F2) was crashing when there were more than MAX_NUM_UNITS (=250) units under UWT. This was the consequence of using a fixed-size array. Fix by switching to std::vector. Reported by Corbeau.
This keeps the interface consistent with get_units_waiting_data() and is generally safer.
lmoureaux
force-pushed
the
bugfix/unit-view-crash
branch
from
483acd3 to
8a6dc92
Compare
blabber
approved these changes
Oct 25, 2024
jwrober
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The units view was crashing when more than 250 units were on UWT. This was reported by @Corbeau-1 on Discord (Sim06).
The second commit isn't strictly necessary but keeps things consistent.