improved battle messages (closes #2358) #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Since this changes the network protocol, we need to check that the behavior of an old (3.0) client connecting to a new server. It is understood that the old client will not behave optimally, but it shouldn't crash or complain too loudly.
I also have comments on the code below. I haven't checked the new logic yet.
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
lmoureaux
reviewed
Sep 4, 2024
lmoureaux
reviewed
Sep 4, 2024
lmoureaux
reviewed
Sep 4, 2024
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
hugomflavio
force-pushed
the
issue_2358
branch
from
8bfc546 to
773a94f
Compare
lmoureaux
reviewed
Sep 5, 2024
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
Co-authored-by: Louis Moureaux <[email protected]>
lmoureaux
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.