Fix wrapping redundant cities in the economics view #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a variable by using the size of the list of redundant cities to count them.
We were resizing columns to avoid wrapping with resizeColumnsToContents, then resizing rows. This produced horizontal scrolling and strange behaviour when the redundant list got long. Fix this by: 1) Setting the last column (redundant cities) to use all remaining space, and 2) Adjusting the width of all columns except the last. Closes longturn#2289.
jwrober
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrapping redundant cities in the economics view
We were resizing columns to avoid wrapping with resizeColumnsToContents,
then resizing rows. This produced horizontal scrolling and strange
behaviour when the redundant list got long.
Fix this by:
space, and
Closes #2289.
Tested locally by inverting the logic of
get_economy_report_datato show all non-redundant cities (which is usually many).