Improve sizing and scrolling of the unit choice popup #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit selection popup for stacks in the open (and in allied cities) didn't behave very well with many units: its width remained fixed to 4 and it was showing at most 12 units -- quite a small stack for a serious attack. In addition, the last row was in some cases inaccessible due to a scrolling bug (maybe Wayland-specific; longturn#2285). Increase the base width of the menu to 5 units (a loaded Galleon), and further to 6 when there are more than 25 units. Show up to 36 units (four fully loaded Transports) at once before resorting to scrolling. Fix the scrolling bug, which was related to scroll events with deltaY=0 being interpreted as scrolling upwards. Closes longturn#2285.
|
I never get more than 4 columns There are 46 Howitzers on the tile. Other than that seems to work. |
|
Hmm, this 12-units layout looks like the old behavior... are you sure the patch is applied? |
|
No one saw anything... :)
|
jwrober
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit selection popup for stacks in the open (and in allied cities) didn't behave very well with many units: its width remained fixed to 4 and it was showing at most 12 units -- quite a small stack for a serious attack. In addition, the last row was in some cases inaccessible due to a scrolling bug (maybe Wayland-specific; #2285).
Increase the base width of the menu to 5 units (a loaded Galleon), and further to 6 when there are more than 25 units. Show up to 36 units (four fully loaded Transports) at once before resorting to scrolling.
Fix the scrolling bug, which was related to scroll events with deltaY=0 being interpreted as scrolling upwards.
Closes #2285.
This was likely already a bug in 3.0, so we should consider backporting the fix if there is another dot release.