Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visual Studio installation steps to current #2267

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Apr 5, 2024

No related issue.

@jwrober jwrober requested a review from blabber April 5, 2024 22:24
Copy link
Collaborator

@blabber blabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the longstanding formatting nitpick this looks good.

docs/Contributing/visual-studio.rst Outdated Show resolved Hide resolved
@jwrober
Copy link
Collaborator Author

jwrober commented Apr 6, 2024

Apart from the longstanding formatting nitpick this looks good.

Formatting nitpick?

@blabber
Copy link
Collaborator

blabber commented Apr 6, 2024

I meant the question if "Individual components" should be tagged as guilabel. Not being a native speaker I probably did not express myself too well 😅

What I meant: 1. It's not a big issue (nitpick) and 2. it's been this way a while (longstanding). I approved the PR because I am not sure if this really is an issue and your changes look good :)

@jwrober
Copy link
Collaborator Author

jwrober commented Apr 8, 2024

Sounds good! Fun w/ Engrish LoL

@jwrober jwrober enabled auto-merge (rebase) April 8, 2024 21:35
@jwrober jwrober merged commit 2e8becf into longturn:master Apr 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants