Implement tileset options #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrober
approved these changes
Mar 31, 2024
Options will be boolean values that the user can modify. They will allow loading non-default sprites, modifying the appearance of a tileset according to the what the user prefers.
This is a start, but the implementation is not optimal and the settings aren't saved.
"extra" sprites are specified directly in the tilespec. This isn't used by any tileset I know of.
Using bools enables better bookkeeping of which options are set or not.
This isn't doing anything yet.
The user-visible name might change, but as long as the tilespec isn't renamed this shouldn't matter for options.
Instead of duplicating the whole tileset with another name, add an option called "cimpletoon" to load cimpletoon units. Support is added to amplio2 and hexemplio.
Since amplio2 and hexemplio can now be made to use cimpletoon units, there is no point in keeping separate tilesets. Add code to migrate user configurations before dropping cimpletoon and toonhex.
It has been made obsolete by tileset options.
It has been made obsolete by tileset options.
lmoureaux
force-pushed
the
feature/tileset-options
branch
from
5e0fc10 to
785a0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general solution for requests like #2037. With these changes, tilesets can specify arbitrary options that modify their appearance according to what the users prefers. This feature is documented in a new page under Modding/Tilesets.
I used this feature to remove
cimpletoonandtoonhex, as they were just copies ofamplio2andhexempliowith the Cimpletoon units. This is now supported as an option to the main tilesets, reducing maintenance burden. So this PR adds a feature that reduces the total number of lines :DCimpletoon and Toonhex users will automatically be migrated to Amplio2 or Hexemplio with the appropriate configuration.
The ultimate test would be implementing #2037 for shipped tilesets 😃