Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about non-transport FerryBoat units #2240

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Warn about non-transport FerryBoat units #2240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions server/ruleset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
#include "script_server.h"

#include "ruleset.h"
#include "unittype.h"

// RULESET_SUFFIX already used, no leading dot here
#define RULES_SUFFIX "ruleset"
Expand Down Expand Up @@ -2303,6 +2304,15 @@ static bool load_ruleset_units(struct section_file *file,
ok = false;
break;
}

// L_FERRYBOAT makes the AI consider the unit as a transport.
// Ensure it can actually transport something.
if (utype_has_role(u, L_FERRYBOAT) && u->transport_capacity == 0) {
qCWarning(ruleset_category,
"\"%s\": Unit %s has FerryBoat flag but cannot transport",
filename, utype_rule_name(u));
BV_CLR(u->roles, L_FERRYBOAT - L_FIRST);
}
}
unit_type_iterate_end;
}
Expand Down
Loading