Fix the macOS CI build #2220
Merged
Fix the macOS CI build #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macOS CI stopped working, seemingly because multiple Python versions are installed simultaneously. We forced the Python version in response to longturn#2069. There is now a proper fix for longturn#2069 in upstream vcpkg. Update the vcpkg version so we can use it.
|
Is this still ready for review? This did not fix the build, so I guess work on this PR is ongoing. |
Right, thanks. Switched to draft |
|
Let's squash and merge if the pipeline succeeds |
|
100%, so only one commit goes into master and stable branches. |
jwrober
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS CI stopped working, seemingly because multiple Python versions are installed simultaneously. We forced the Python version in response to #2069. There is now a proper fix for #2069 in upstream vcpkg. Update the vcpkg version so we can use it.