fcmp: Fix bogus "query failed" message #2208
Conversation
When the modpack installer updates an already installed modpack, it emits a bogus critical message that a query failed with error code 100. Error code 100 is `SQLITE_ROW` and is not really an error, but signals that a data row has been successfully read. `SQLITE_ROW` is also an expected return value in `mpdb_update_modpack`. Change the check for failed to queries to ignore `SQLITE_ROW`.
blabber
force-pushed
the
bugifx/bogus_query_failed
branch
from
8a1df08 to
5bf53ad
Compare
|
That's what I get for trying to get rid of a misleading message :D |
|
I didn't require changes at this point, just want to understand better 😂 We can also open an issue to check |
Make sure that every prepared statement in `mpdb_query` is finalized.
This changes the return value as an side effect (see below), change
return value checks accordingly.
This commit changes the return value of `mpdb_query`, as the old code
contained this special handling for `ret == SQLITE_DONE`:
```
if (ret == SQLITE_DONE) {
ret = sqlite3_finalize(stmt);
}
```
This not only finalized the prepared statement, but also changed `ret`
to `SQLITE_OK`. After this commit `mpdb_query` returns either
`SQLITE_DONE` or `SQLITE_ROW`, instead of `SQLITE_OK` or `SQLITE_ROW`.
Make sure that every prepared statement in `mpdb_installed_version` is finalized. After finalizing the pointer returned by `sqlite3_column_text` becomes invalid and we must duplicate the string.
No functional changes.
Delete the strings returned by `mpdb_installed_version`.
|
Thanks for the improved memory handling! Am I officially allowed to run a build with |
|
Feel free :) I don't think I've made anything worse, but I don't know what surprises might linger in the code. And I'm not sure whether the |
A |
When the modpack installer updates an already installed modpack, it emits a bogus critical message that a query failed with error code 100.
Error code 100 is
SQLITE_ROWand is not really an error, but signals that a data row has been successfully read.SQLITE_ROWis also an expected return value inmpdb_update_modpack.Change the check for failed queries to ignore
SQLITE_ROW.