Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Qt to use FreeType on Windows #2160

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

lmoureaux
Copy link
Contributor

Rendering of the Libertinus fonts was terrible with the (default) DirectWrite backend on Windows. Install a qt.conf file forcing Qt to use FreeType.

While reviewing Qt options I also found a way to make the window title bars dark if the user chose a dark theme. I enabled this as well.

Finally I moved files used for the Windows installer to dist/windows in an effort to organize that folder.

Rendering of the Libertinus fonts was terrible with the (default) DirectWrite
backend on Windows. Install a `qt.conf` file forcing Qt to use FreeType.

While reviewing Qt options I also found a way to make the window title bars
dark if the user chose a dark theme. I enabled this as well.

Finally I moved files used for the Windows installer to dist/windows in an
effort to organize that folder.
@lmoureaux lmoureaux requested a review from jwrober January 19, 2024 00:49
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still evaluating, but to be consistent we should place the icons into the windows dir.

cmake/FreecivInstall.cmake Show resolved Hide resolved
@jwrober
Copy link
Collaborator

jwrober commented Jan 20, 2024

My first test run on msys2 didn't get the .conf file installed. I'm trying again.

@jwrober jwrober self-requested a review January 20, 2024 20:53
@jwrober jwrober merged commit ad693e5 into longturn:master Jan 20, 2024
20 checks passed
@jwrober jwrober added the back-port back-port candidate label Jan 20, 2024
@lmoureaux lmoureaux deleted the bugfix/windows-font-rendering branch January 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port back-port candidate
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants