Rewrite drawing of citizen sprites to use multiple rows #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a city is too large, the current logic will cause citizen sprites to overlap, which isn't very ergonomic. Instead, draw citizens in rows of a max size so players can see all of them. Also fix specialist rotating logic which was broken when citizen sprites were overlapping.
lmoureaux
reviewed
Jan 8, 2024
lmoureaux
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things in this PR:
CITIZENS_PER_ROWcity_labeland several other places to prevent them being squished by the unit list when a city has too many units in itGiven that I don't really know C++, this is on a best-effort basis, but hopefully it's at least a bit helpful.
Fixes #2041
Could partially work for #1904 as well, since that's caused by too many citizens in the second tab