Implement two broken governor options #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two bugs: * Only the city center was considered as a potential food source * Food surplus above the computed optimized minimum was still encouraged See longturn#2058.
Now that we have a UI to set allow_specialists, implement it. Do it by not including specialists in the list of possible citizen assignments. See longturn#2058.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the governor option to "optimize" food for growth, trying to find as much food as possible without having excess food when growing. The implementation of this feature isn't optimal but I found it easier to fix the current code than to implement something better.
I also implemented the governor option to disallow using specialists. The field for this was implemented in 2003 and maybe it was working back then, but I don't remember it working in any of the versions I played.
Closes #2058.