Take team_pooled_research into account when looping over research #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of valid research objects is the number of teams when team_pooled_research is enabled, and the number of players when it is disabled. The code was always assuming the first case, which created bugs in team games without pooled research. Fixes 22c0c4b.
jwrober
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of valid research objects is the number of teams when team_pooled_research is enabled, and the number of players when it is disabled. The code was always assuming the first case, which created bugs in team games without pooled research.
Fixes 22c0c4b.
Observed in the LT76Team test game.
Test plan:
/set team_pooled_r en)