Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Guangzhou Port Facility graphic #1634

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fix Guangzhou Port Facility graphic #1634

merged 1 commit into from
Dec 26, 2022

Conversation

lmoureaux
Copy link
Contributor

No description provided.

@lmoureaux lmoureaux requested a review from jwrober December 26, 2022 16:55
@daavko
Copy link
Collaborator

daavko commented Dec 26, 2022 •
edited
Loading

Since you're already touching the file, could you also fix the wrong graphic used for b.ecclesiastical_palace a couple lines up? It currently uses the -small variant, it should use the regular one. Probably a copy/paste error

I was about to create a PR for that, but then I saw this one is open, so better to fix it all in one I guess :)

jwrober
jwrober approved these changes Dec 26, 2022
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing some other typos and CnP errors (per daavko's post). I'll make another PR to fix those.

@jwrober jwrober merged commit dd79349 into longturn:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmoureaux @daavko @jwrober