Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diplomacy Visibility #1613

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Dec 18, 2022

Similar to how the Research view button will blink on the top bar when no research target is set. We enable the same visual feature to remind a player that there are open meetings to attend to.

Closes #1421

@jwrober jwrober requested a review from lmoureaux December 18, 2022 23:56
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Some suggestions to shorten the code, feel free to accept or reject

client/diplodlg.cpp Outdated Show resolved Hide resolved
client/diplodlg.cpp Outdated Show resolved Hide resolved
client/diplodlg.cpp Outdated Show resolved Hide resolved
client/plrdlg.cpp Outdated Show resolved Hide resolved
client/plrdlg.cpp Outdated Show resolved Hide resolved
client/plrdlg.cpp Outdated Show resolved Hide resolved
Similar to how the Research view button will blink on the top bar when no research target is set. We enable the same visual feature to remind a player that there are open meetings to attend to.
@jwrober jwrober force-pushed the feature/diplomacy-visibility branch from 0f38919 to e8891b3 Compare December 21, 2022 18:31
@jwrober jwrober merged commit ec0ecac into longturn:master Dec 21, 2022
@jwrober jwrober deleted the feature/diplomacy-visibility branch January 8, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a clean visual way to know if a diplomacy session is open
2 participants