Add scroll bars to the city screen when info doesn't fit #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout of the city dialog was getting bad on 1366x768 screens because there was not enough vertical space. Add scroll bars as a minimal change for 3.0. Closes longturn#1584.
|
At 720p. Any way to move this side of the box over to the left? |
|
This is strange, I'll investigate |
|
I couldn't reproduce, anything special I need to know? (Is this LTT/Royale?) |
It's a Royale game. Here is the save used to take the pic. |
|
I'm getting the same |
|
The layout is strange, has a separator on the left but not on the right and nothing is centered: |
|
We've got this issue #728 that talks about centering the dialog better. |
jwrober
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout of the city dialog was getting bad on 1366x768 screens because there was not enough vertical space. Add scroll bars as a minimal change for 3.0.
Closes #1584.
Need to compile twice since this changes the .ui