Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random button ordering in PAGE_LOAD #1590

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Fix random button ordering in PAGE_LOAD #1590

merged 2 commits into from
Dec 17, 2022

Conversation

lmoureaux
Copy link
Contributor

Ensure that "Browse..." always has a different role than Ok, otherwise Qt does fancy things.

Closes #1582.

@lmoureaux
Fix random button ordering in PAGE_LOAD
feb4b40 
Ensure that "Browse..." always has a different role than Ok, otherwise Qt does
fancy things.

Closes longturn#1582.
@lmoureaux lmoureaux requested a review from jwrober December 11, 2022 17:12
jwrober
jwrober requested changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite right yet
image
image

@lmoureaux
Copy link
Contributor Author

W.T.F.

@jwrober
Copy link
Collaborator

jwrober commented Dec 12, 2022

to recreate (at least on my local)

  1. open the game, notice what theme you are on
  2. click open save game and notice button layout
  3. click cancel to go back to the main start screen
  4. click options to change the theme
  5. click open save game and notice button layout

@lmoureaux
Set button layout in Classic theme
19238d8 
Was inconsistent wrt NightStalker.

See longturn#1590.
@lmoureaux lmoureaux requested a review from jwrober December 16, 2022 23:47
jwrober
jwrober approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now its the same on both!

@jwrober jwrober merged commit 8aa6de0 into longturn:master Dec 17, 2022
@lmoureaux lmoureaux deleted the bugfix/random-button-ordering branch December 28, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Savegame load page different between classic and nightstalker themes
2 participants
@lmoureaux @jwrober