Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead themes #1572

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Remove dead themes #1572

merged 2 commits into from
Dec 10, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Dec 9, 2022

Closes #1556

@jwrober
Copy link
Collaborator Author

jwrober commented Dec 9, 2022 •
edited
Loading

There is one "fix" to make this PR ready.

  1. Figure out why Classic is placed in the options dialog even though NightStalker is default when one of the two is not set in the rc file

My good buddy @lmoureaux said he will fix this for me :)

@lmoureaux
Don't allow setting string options to disallowed values
7be1cfa 
The client already didn't do it, but it was possible to set illegal values from
the configuration file. Prevent this from happening.

See longturn#1572.
@lmoureaux
Copy link
Contributor

My good buddy @lmoureaux said he will fix this for me :)

Done

@jwrober jwrober marked this pull request as ready for review December 9, 2022 22:59
@lmoureaux lmoureaux merged commit c16a91f into longturn:master Dec 10, 2022
@jwrober jwrober deleted the remove-themes branch January 18, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unmaintained and unused themes
2 participants
@jwrober @lmoureaux