Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable resizable minimap panel #1542

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Enable resizable minimap panel #1542

merged 3 commits into from
Nov 30, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Nov 30, 2022

Closes #1489

@jwrober jwrober marked this pull request as ready for review November 30, 2022 00:41
@jwrober jwrober requested a review from lmoureaux November 30, 2022 00:41
lmoureaux
lmoureaux reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only, I need to test if it remembers the size after closing and reopening (that code will always surprise me)

client/minimap_panel.h Outdated Show resolved Hide resolved
@lmoureaux lmoureaux self-requested a review November 30, 2022 18:27
lmoureaux
lmoureaux approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can got without remembering the size for now. What we have for the chat is broken anyway, and it would make sense to use a common solution.

@jwrober jwrober merged commit cf6a4d5 into longturn:master Nov 30, 2022
@jwrober jwrober deleted the feature/minimap-resize branch December 1, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the minimap resizeable
2 participants
@jwrober @lmoureaux