Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the network page when autoconnecting to an auth-enabled server #1307

Merged

Conversation

lmoureaux
Copy link
Contributor

Closes #540.

@lmoureaux lmoureaux requested a review from jwrober August 22, 2022 00:21
@jwrober
Copy link
Collaborator

jwrober commented Aug 22, 2022

@lmoureaux How would you suggest I test this?

@lmoureaux
Copy link
Contributor Author

Start games, stop them, connect to other games, run LAN scans, start a game and change your mind for a scenario, oh no you wanted to load a save instead, ...

@jwrober
Copy link
Collaborator

jwrober commented Aug 23, 2022

Actually, I will follow the directions in PR #1304 when it is published to setup an auth enabled server and test against that.

Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting how one line can fix something. I was able to setup an auth enabled server and recreate the bug and then it went away with this patch.

@psampathkumar psampathkumar merged commit 687289b into longturn:master Aug 24, 2022
@psampathkumar psampathkumar deleted the bugfix/autoconnect-auth-switch-page branch August 24, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoconnecting to a auth-enabled server doesn't show the password prompt
3 participants