-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump top bar icons to 22px #1282
Bump top bar icons to 22px #1282
Conversation
What is so magical about 22px? Where do we set the height of the top bar? At 22px, the icons are still quite small. I was looking for the icons to be much larger - e.g. make them much more prominent and fill a large portion of the height of the top bar. Even with the gui as small as I can get it on my laptop, I still think the icons could be bigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
The height of the top bar is a function of the font size. 22px is a about the height of two lines of text at a size of 12px. Making icons taller also implies making them wider, without changing the horizontal space between the icon and the text, so this starts to look strange if you make them very large. 22px looked "right" on my display. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with the value on my local. 30px seems like a good number too, but I'm not going to quibble over 8px. This is still better than it was.
Let's revisit after #1287 |
So what do you think with the new colors? |
It's a fixed-size png, not a scalable icon |
Closes #1254.