Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump top bar icons to 22px #1282

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

lmoureaux
Copy link
Contributor

Closes #1254.

@lmoureaux lmoureaux requested a review from jwrober August 15, 2022 02:10
@jwrober
Copy link
Collaborator

jwrober commented Aug 15, 2022

What is so magical about 22px? Where do we set the height of the top bar? At 22px, the icons are still quite small. I was looking for the icons to be much larger - e.g. make them much more prominent and fill a large portion of the height of the top bar. Even with the gui as small as I can get it on my laptop, I still think the icons could be bigger

image

Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@lmoureaux
Copy link
Contributor Author

The height of the top bar is a function of the font size. 22px is a about the height of two lines of text at a size of 12px. Making icons taller also implies making them wider, without changing the horizontal space between the icon and the text, so this starts to look strange if you make them very large. 22px looked "right" on my display.

@jwrober jwrober self-requested a review August 15, 2022 15:21
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with the value on my local. 30px seems like a good number too, but I'm not going to quibble over 8px. This is still better than it was.

@lmoureaux
Copy link
Contributor Author

Let's revisit after #1287

@lmoureaux
Copy link
Contributor Author

So what do you think with the new colors?

@jwrober
Copy link
Collaborator

jwrober commented Aug 19, 2022

So what do you think with the new colors?

I still think they could be bigger. I do still like 30px. I also see something weird with the nations view button. The icon is missing or oddly small for some of the themes

image
image

@lmoureaux
Copy link
Contributor Author

I also see something weird with the nations view button. The icon is missing or oddly small for some of the themes

It's a fixed-size png, not a scalable icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the size of the icons on the buttons on the top bar
2 participants