Don't default to huge fonts of HiDpi systems #1281
Conversation
We have enabled Qt's transparent handling of HiDpi, and thus the manual scaling that was done in configure_fonts() was useless. Worse, on HiDpi diplays, it would choose larger fonts to make the UI bigger, which Qt also does internally. This resulted in huge fonts on such systems. Simply delete the scaling code. Use the opportunity to tidy up a bit. See longturn#1273.
|
So this is better. Any way to make the font closer to 12 to 14pt, vs 16? Also I don't think help label has a default. Why is it size 9?
What about using more generic OS non-specific font names like |
I stand corrected, these are not in Windows (at least not in a fresh install of Win10) so if we want more control, might want to think about shipping some font files. At least per wikipedia, Liberation fonts are OSS - https://en.wikipedia.org/wiki/Liberation_fonts |
|
I'm not pretending to fix all font issues in this PR, just the super large fonts that appeared in some instances. I consider this a bug fix, even if related to #1273, since the defaults weren't applied correctly. Changing the defaults should be another PR IMHO. To bundle fonts, we'd need to change the Windows and Mac installers, which is an even wider scope. |
We have enabled Qt's transparent handling of HiDpi, and thus the manual scaling
that was done in configure_fonts() was useless. Worse, on HiDpi diplays, it
would choose larger fonts to make the UI bigger, which Qt also does internally.
This resulted in huge fonts on such systems.
Simply delete the scaling code. Use the opportunity to tidy up a bit.
See #1273.