Don't use the capital for the tooltip of the city top bar button #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a proxy for QWidget::setToolTip (notice the different capitalization). We don't need that.
The tooltip of the "Cities" button in the top bar was showing the number of cities by querying the help text for the player's capital. Now that we have better help texts, this string is more specific about the capital and breaks in the context of the top bar. Change back the tooltip to what it was before, i.e. a simple city counter.
jwrober
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooltip of the "Cities" button in the top bar was showing the number of
cities by querying the help text for the player's capital. Now that we have
better help texts, this string is more specific about the capital and breaks in
the context of the top bar.
Change back the tooltip to what it was before, i.e. a simple city counter.