Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the city size and citizen happiness next to other city stats #1204

Merged
merged 5 commits into from
Aug 7, 2022

Conversation

lmoureaux
Copy link
Contributor

Closes #438.
The citizen types (happiness and entertainers) is shown in the tooltip.

The patch itself is rather small, but there's a lot of refactoring to make it less error-prone in the end.

This was stupid design.
Makes us save a few lines and makes the code easier to understand.
This makes the code much more readable.
It's not the best layout ever but it works.

See longturn#438.
The easiest way to make tooltips use a fixed width font is to use a <pre> HTML
element.
@lmoureaux lmoureaux requested a review from jwrober August 6, 2022 20:35
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@jwrober jwrober merged commit 72a72bd into longturn:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add city size and unhappy to general tab
2 participants