Fix new Coverity warnings #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity CID 1435592. Coverity CID 1435613. Coverity CID 1435813.
This fixes commit 1294672. Coverity CID 1435782.
The function city_production_model::setData was doing nothing and always returning false, just like in the base class. Remove it. Coverity CID 1435807.
If someone wants to require stupid password rules, they should do it using lua and not by building a special server version. Coverity CID 1435808.
The client was crashing when Ctrl+Alt+clicking outside of the map (this shortcut is bound to the "create link" action). Check that we're within bounds before attempting anything. Coverity CID 1490725.
|
The fails dont look like garbage, WA and Win doesnt seem to like the |
Turn init_units into an std::array because it's inherently better. Coverity CID 1490804.
lmoureaux
force-pushed
the
bugfix/coverity
branch
from
921a9dd to
3cb4661
Compare
|
All the checks have passed now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of Coverity warnings popped up in the last month. This should clear them all.
Special thanks to Synopsis for 55336e7: The client was crashing when Ctrl+Alt+clicking outside of the map (this shortcut is bound to the "create link" action).