Resize the canvas a bit less often in map_canvas_resized #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
added
refactoring
|
Does this PR need rebasing to master after 1169 has been merged? |
Yes |
The cached mapview texture always gets resized in tile_width/height increments. One needs to redraw only when the cache got resized, not every time. The code doing that had been broken since 9bd5b4a; fix it.
lmoureaux
force-pushed
the
bugfix/less-canvas-resizing
branch
from
9f76f55 to
ccb37df
Compare
|
Rebased |
jwrober
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached mapview texture always gets resized in tile_width/height increments.
One needs to redraw only when the cache got resized, not every time. The code
doing that had been broken since 9bd5b4a; fix it.
This should slightly improve performance when resizing the main window.
On top of #1169