Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new columns to nations report #1044

Merged
merged 2 commits into from
Jun 25, 2022

Conversation

psampathkumar
Copy link
Contributor

Add columns about
government, culture, gold, %tax, %science, %lux, and current research

Ported from freeciv/freeciv@8510bf8

@psampathkumar psampathkumar force-pushed the feature/nations-report branch from 8a9415d to eb6172a Compare June 25, 2022 14:50
Add columns about
government, culture, gold, %tax, %science, %lux, and current research

Ported from: freeciv/freeciv@8510bf8
Fixes longturn#1004
@psampathkumar psampathkumar force-pushed the feature/nations-report branch from eb6172a to 5b7b830 Compare June 25, 2022 14:56
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many suggestions but you'll see they're always the same

client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
client/plrdlg_common.cpp Outdated Show resolved Hide resolved
Remove unnecessary variable
@lmoureaux lmoureaux enabled auto-merge (rebase) June 25, 2022 15:53
@lmoureaux lmoureaux merged commit d452418 into longturn:master Jun 25, 2022
@psampathkumar psampathkumar deleted the feature/nations-report branch June 25, 2022 16:01
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this pull request Aug 13, 2022
@lmoureaux lmoureaux mentioned this pull request Aug 13, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this pull request Aug 15, 2022
lmoureaux added a commit that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants