Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for hiding the terrain #449

Closed
lmoureaux opened this issue Apr 26, 2021 · 1 comment
Closed

Drop support for hiding the terrain #449

lmoureaux opened this issue Apr 26, 2021 · 1 comment
Labels
question Further information is requested

Comments

@lmoureaux
Copy link
Contributor

It is possible to configure the client to hide the terrain, resulting in a map like this:
image

I don't see the value of this feature. If someone wants to play without terrain information (and thus miss a lot of info), s.he can create a tileset without terrain graphics.

The feature is also a pain for #430, so I would like to drop it.
@lmoureaux lmoureaux added the question Further information is requested label Apr 26, 2021
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 26, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
21500aa 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
@lmoureaux lmoureaux mentioned this issue Apr 26, 2021
Merged
@lmoureaux
Copy link
Contributor Author

More info:

  • Some people appear to use this as a "distraction free" mode. Arguably a distraction free tileset would also work if switching is not too hard (which was already the case, terrain could only be toggled from the settings dialog).
  • The original commit isn't very informative.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 23, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
5b2bb63 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 31, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
bd4b6be 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Sep 11, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
0ad587f 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Sep 12, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
3521a8e 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Sep 12, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
9612bce 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Sep 12, 2021
@lmoureaux
Migrate the LAYER_BACKGROUND code to its class
4993bd5 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
@lmoureaux @psampathkumar
Migrate the LAYER_BACKGROUND code to its class
4dca441 
This commit migrates the code to draw the LAYER_BACKGROUND sprites to the
layer_background class. The feature that allowed to hide the terrain was not
migrated; see longturn#449.

Closes longturn#449.
See longturn#430.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmoureaux