Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units view: "find nearest unit" does not always show map #2451

Closed
blabber opened this issue Dec 4, 2024 · 0 comments · Fixed by #2452
Closed

Units view: "find nearest unit" does not always show map #2451

blabber opened this issue Dec 4, 2024 · 0 comments · Fixed by #2452
Assignees
@blabber
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@blabber
Copy link
Collaborator

blabber commented Dec 4, 2024

Describe the bug
Using "find nearest unit" in the units view, opens the last view that was open before opening the units view. This is not always the map.

To Reproduce
Steps to reproduce the behavior:

  1. Open the cities view
  2. Switch to the units view
  3. Click the "find nearest unit" button
  4. See that the cities view is displayed

Expected behavior
After clicking "find nearest unit", the map should be displayed with the nearest unit selected.

Platform and version (please complete the following information):

  • OS: FreeBSD 14.2-RELEASE
  • Freeciv21 version: 3.1-rc.1
  • Ruleset/Longturn game (if applicable): any

Additional context
Noticed while playing Sim06
@blabber blabber added bug Something isn't working gui This issue requires changes to the user interface labels Dec 4, 2024
@blabber blabber self-assigned this Dec 4, 2024
blabber added a commit to blabber/freeciv21 that referenced this issue Dec 4, 2024
@blabber
Units view: Show map after clicking "find nearest unit"
1fca84a 
Views are no longer destroyed, if the view is switched. That's the
reason why the `popdown_units_view`, that is called after clicking
"find nearest unit", is no longer guaranteed to show the map.

Closes longturn#2451
@blabber blabber mentioned this issue Dec 4, 2024
Merged
jwrober pushed a commit that referenced this issue Dec 6, 2024
@blabber @jwrober
Units view: Show map after clicking "find nearest unit"
15cfe08 
Views are no longer destroyed, if the view is switched. That's the
reason why the `popdown_units_view`, that is called after clicking
"find nearest unit", is no longer guaranteed to show the map.

Closes #2451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blabber blabber

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Units view: Show map after clicking "find nearest unit" blabber/freeciv21
1 participant
@blabber