Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ESC to close build window #2383

Closed
Corbeau-1 opened this issue Sep 10, 2024 · 4 comments · Fixed by #2407
Closed

Allow ESC to close build window #2383

Corbeau-1 opened this issue Sep 10, 2024 · 4 comments · Fixed by #2407
Labels
enhancement New feature or request gui This issue requires changes to the user interface

Comments

@Corbeau-1
Copy link
Contributor

300168893-4d2d67c5-8d2a-4226-970b-7f778b221f3e

This window (widget?) is somewhat tricky to close. ESC doesn't close it, I need to click somewhere else, but there is a possibility that clicking somewhere else may activate something else. So, basically, ESC would do.

@Corbeau-1 Corbeau-1 added enhancement New feature or request Untriaged This issue or PR needs triaging labels Sep 10, 2024
@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Sep 10, 2024
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 18, 2024
There were already a Cancel button and right click to close, but ESC is
more natural.

Closes longturn#2383.
@lmoureaux
Copy link
Contributor

This will be added in the next version. As a workaround, you can use right click or the "Cancel" button at the end of the list.

@Corbeau-1
Copy link
Contributor Author

Wait, you could close it with right-click?

facepalm

@lmoureaux
Copy link
Contributor

Yeah it's one of those "features" one can only discover by reading the code

@Corbeau-1
Copy link
Contributor Author

I mean, to be honest, rightclick is for me even more convenient thatn ESC.

In cases like this it would probably be cool just to put up a note in a visible place, something like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants