Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CONTRIBUTING file referencing RTD #2376

Closed
lmoureaux opened this issue Sep 9, 2024 · 0 comments · Fixed by #2377
Closed

Add a CONTRIBUTING file referencing RTD #2376

lmoureaux opened this issue Sep 9, 2024 · 0 comments · Fixed by #2377
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@lmoureaux
Copy link
Contributor 

          > Also, best practice is to place new code into a branch and not `master` - https://longturn.readthedocs.io/en/latest/Contributing/pull-request.html

It might be a good idea to link to this somewhere in a CONTRIBUTING file or the README. I looked through the project repo and github wiki and didn't see any references to these docs.

Originally posted by @XHawk87 in #2372 (comment)
@lmoureaux lmoureaux added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 9, 2024
lmoureaux added a commit that referenced this issue Sep 9, 2024
@lmoureaux
Create CONTRIBUTING.md
d45ee2b 
This provides a link to our contributing guidelines at a standard and easy-to-find place.

Closes #2376.
@lmoureaux lmoureaux mentioned this issue Sep 9, 2024
Merged
lmoureaux added a commit that referenced this issue Sep 9, 2024
@lmoureaux
Add contributing docs to README.md
a7b751c 
See #2376.
@jwrober jwrober closed this as completed in fc77074 Sep 9, 2024
jwrober pushed a commit that referenced this issue Sep 9, 2024
@lmoureaux @jwrober
Add contributing docs to README.md
88e3379 
See #2376.
lmoureaux added a commit that referenced this issue Oct 26, 2024
@lmoureaux
Create CONTRIBUTING.md
dbadefb 
This provides a link to our contributing guidelines at a standard and easy-to-find place.

Closes #2376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create CONTRIBUTING.md longturn/freeciv21
1 participant
@lmoureaux