Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mass-buying in the city list should buy cheapest first #2311

Closed
lmoureaux opened this issue Jul 5, 2024 · 0 comments · Fixed by #2321
Closed

Mass-buying in the city list should buy cheapest first #2311

lmoureaux opened this issue Jul 5, 2024 · 0 comments · Fixed by #2321
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.1-stable

Comments

@lmoureaux
Copy link
Contributor

Describe the bug
Buying in the list of cities seemingly buys from the top of the list, however it is sorted. It should buy the cheapest options.

To Reproduce
Steps to reproduce the behavior:

  1. Get a game with plenty of gold and many cities
  2. Switch all cities to unit building
  3. Sort from most to least expensive
  4. Buy all
  5. See the most expensive units were bought

Expected behavior
The cheapest units are bought.

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: master
@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface labels Jul 5, 2024
@lmoureaux lmoureaux added this to the v3.1-stable milestone Jul 5, 2024
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jul 7, 2024
@lmoureaux
Always buy the cheapest options in the cities view
b1f8c86 
When buying production with multiple cities selected in the cities view,
always buy from the cheapest cities. This ensures that we buy from as
many cities as possible.

Closes longturn#2311.
@lmoureaux lmoureaux mentioned this issue Jul 7, 2024
Merged
@jwrober jwrober closed this as completed in 88bb015 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.1-stable
Development

Successfully merging a pull request may close this issue.

Always buy the cheapest options in the cities view lmoureaux/freeciv21
1 participant
@lmoureaux