Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion dai_is_ferry(ferry, ait) failed #2238

Closed
jwrober opened this issue Mar 26, 2024 · 4 comments · Fixed by #2240
Closed

Assertion dai_is_ferry(ferry, ait) failed #2238

jwrober opened this issue Mar 26, 2024 · 4 comments · Fixed by #2240
Labels
bug Something isn't working server This issue requires changes to the server

Comments

@jwrober
Copy link
Collaborator

jwrober commented Mar 26, 2024

Describe the bug
Assertion while playing Royale rules

To Reproduce
No idea. See SAV file attached.

Expected behavior
No bugs :)

Screenshots
N/A

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-alpha.5
  • Ruleset/Longturn game (if applicable): Royale (the new one, not the one shipped w/ fc21)

Additional context
See attachment
Royale.zip
@jwrober jwrober added bug Something isn't working Untriaged This issue or PR needs triaging labels Mar 26, 2024
@lmoureaux
Copy link
Contributor

Can it be reproduced from the save?

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 26, 2024

Hit done :)

@lmoureaux
Copy link
Contributor 

#1  0x000055555576f3f3 in find_best_city_placement (ait=0x555555d76120 <ai_types>, punit=0x5555598fd000, look_for_boat=true, use_virt_boat=true) at /home/louis/freeciv/freeciv21/ai/default/aisettler.cpp:890
#2  0x0000555555772e53 in contemplate_new_city (ait=0x555555d76120 <ai_types>, pcity=0x5555577d68b0) at /home/louis/freeciv/freeciv21/ai/default/aisettler.cpp:1249
#3  0x00005555557a087b in dai_manage_cities (ait=0x555555d76120 <ai_types>, pplayer=0x5555576cab80) at /home/louis/freeciv/freeciv21/ai/default/daicity.cpp:946
#4  0x0000555555769ed9 in dai_do_last_activities (ait=0x555555d76120 <ai_types>, pplayer=0x5555576cab80) at /home/louis/freeciv/freeciv21/ai/default/aihand.cpp:765
#5  0x0000555555751b37 in cai_do_last_activities (pplayer=0x5555576cab80) at /home/louis/freeciv/freeciv21/ai/classic/classicai.cpp:462
#6  0x00005555555995bc in end_phase () at /home/louis/freeciv/freeciv21/server/srv_main.cpp:1453
#7  0x00005555555826b3 in freeciv::server::end_phase (this=0x555555f499f0) at /home/louis/freeciv/freeciv21/server/server.cpp:888

@jwrober jwrober added server This issue requires changes to the server bug Something isn't working and removed bug Something isn't working Untriaged This issue or PR needs triaging labels Mar 26, 2024
@lmoureaux
Copy link
Contributor

The Pirogue has the FerryBoat role but cannot transport units. This us a ruleset issue, but it shouldn't generate assertion failures.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Mar 26, 2024
@lmoureaux
Warn about non-transport FerryBoat units
2bacd06 
The FerryBoat flag is only meaningful for units that can transport. Warn when
the flag is set for non-transport units, and unset it. This prevents an
assertion failure later on.

Closes longturn#2238.
@lmoureaux lmoureaux mentioned this issue Mar 26, 2024
Merged
jwrober pushed a commit that referenced this issue Mar 26, 2024
@lmoureaux @jwrober
Warn about non-transport FerryBoat units
32d6f67 
The FerryBoat flag is only meaningful for units that can transport. Warn when
the flag is set for non-transport units, and unset it. This prevents an
assertion failure later on.

Closes #2238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn about non-transport FerryBoat units lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober