Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpack installer fails to create database due to invalid SQL #2128

Closed
daavko opened this issue Jan 3, 2024 · 0 comments
Closed

Modpack installer fails to create database due to invalid SQL #2128

daavko opened this issue Jan 3, 2024 · 0 comments
Labels
bug Something isn't working Untriaged This issue or PR needs triaging

Comments

@daavko
Copy link
Collaborator

daavko commented Jan 3, 2024

Describe the bug
In 471b6c3, all instances of NULL were changed to nullptr. Unfortunately this seems to have been done with a simple search&replace, which also accidentally changed occurences of NULL within SQL embedded in modpack installer code, causing the SQL to be invalid. As a result, the modpack installer fails to create its sqlite table, since NOT nullptr isn't valid SQL syntax.

Those two lines are affected: https://github.com/longturn/freeciv21/blob/master/tools/fcmp/mpdb.cpp#L167-L168

The fix is to turn nullptr back to NULL for those two lines.

Additional context
Discord conversation https://discord.com/channels/378908274113904641/912500712833974322/1192045288723058758

@daavko daavko added bug Something isn't working Untriaged This issue or PR needs triaging labels Jan 3, 2024
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 3, 2024
lmoureaux added a commit that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Untriaged This issue or PR needs triaging
Projects
None yet
Development

No branches or pull requests

1 participant