Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeciv21-manual does not get images needed #1974

Closed
jwrober opened this issue Jun 9, 2023 · 3 comments · Fixed by #2149
Closed

freeciv21-manual does not get images needed #1974

jwrober opened this issue Jun 9, 2023 · 3 comments · Fixed by #2149
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.

Comments

@jwrober
Copy link
Collaborator

jwrober commented Jun 9, 2023

Describe the bug
If you call freeciv21-manual for a ruleset, it will write out the proper files. However it does not get the images needed for terrain, buildings, and wonders.

To Reproduce
Steps to reproduce the behavior:

  1. Open a command terminal
  2. run freeciv21-manual -r civ1
  3. Open civ13.html and notice missing terrain icons. Same with civ14.html, and civ15.html.

Expected behavior
Image files are copied to an images directory and properly referenced.

Screenshots
N/A

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-alpha.1
  • Ruleset/Longturn game (if applicable): N/A

Additional context
There isn't a "--tileset" option, so a default terrain would need to be set (such as Amplio2)

@jwrober jwrober added bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools. labels Jun 9, 2023
@lmoureaux
Copy link
Contributor

How much do we want to support -manual vs pyciv's approach?

@jwrober
Copy link
Collaborator Author

jwrober commented Jun 10, 2023

-manual requires no other dependency and is shipped with the game. Maybe it should just be image-free in the HTML output? I don't want to get rid of it altogether I don't think.

@jwrober
Copy link
Collaborator Author

jwrober commented Jul 18, 2023

Coming back to this... I think an edit to freeciv21-manual to not attempt any images and just generate plain HTML is a easy approach and then we let pyciv do the bigger more "sexy" effort of getting images and generating the RST we need for docs.

blabber added a commit to blabber/freeciv21 that referenced this issue Jan 13, 2024
blabber added a commit to blabber/freeciv21 that referenced this issue Jan 13, 2024
jwrober pushed a commit that referenced this issue Jan 13, 2024
lmoureaux pushed a commit to lmoureaux/freeciv21 that referenced this issue Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants