Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimap out of sync #1657

Closed
Mu-00 opened this issue Dec 29, 2022 · 6 comments · Fixed by #2409
Closed

Minimap out of sync #1657

Mu-00 opened this issue Dec 29, 2022 · 6 comments · Fixed by #2409
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.1-stable

Comments

@Mu-00
Copy link

Mu-00 commented Dec 29, 2022

Clicking on the minimap does not jump you to where you click, and the frame that represents the current view in the minimap also is not where you are.
It happened for me in LT75 and is like that from start in LT76.
@Mu-00 Mu-00 added bug Something isn't working Untriaged This issue or PR needs triaging labels Dec 29, 2022
@jwrober
Copy link
Collaborator

jwrober commented Dec 29, 2022

Can you provide more details? This is why we have the templates to prompt for more information. Any screenshots, means to reproduce, version of the client? I'm in LT76 with you and am having no issues. I am running current master as of today. There are some fixes I think post Beta.7.

@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Dec 30, 2022
@lmoureaux
Copy link
Contributor

Confirmed by multiple users, still unable to reproduce on my end. Suggestion that this is caused by device scaling seems contradicted by one affected user not using it.

@jwrober
Copy link
Collaborator

jwrober commented Dec 31, 2022

I turned scaling on my Kubuntu 22.04 laptop to 125% and the minimap is fine for me as well. Definitely need more details to understand this issue. I'm adding untriaged back until we have a way to reproduce.

@jwrober jwrober added the Untriaged This issue or PR needs triaging label Dec 31, 2022
@lmoureaux
Copy link
Contributor

lmoureaux commented Jan 14, 2023 •
edited
Loading

Observed strange results today when zooming the map, maybe this is related

@lmoureaux
Copy link
Contributor

@wieder-fi says it happens after /take. Could also be when switching game (?)

@lmoureaux lmoureaux removed the Untriaged This issue or PR needs triaging label Aug 12, 2024
@lmoureaux
Copy link
Contributor

@hugomflavio found it's related to switching games. Could reproduce.

@lmoureaux lmoureaux added this to the v3.1-stable milestone Aug 12, 2024
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 21, 2024
@lmoureaux
Save less state in minimap_view
b9d4fe7 
The widget needs to compute horizontal and vertical scaling factors to
map between the displayed minimap (in pixel units) and the computed one
(essentially in tile units). It was computing them on resize events and
storing them, which was causing issues when switching maps. Compute them
when they are needed instead, it's just two float divisions.

Also remove a bunch of unused variables from the class.

Closes longturn#1657.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 21, 2024
@lmoureaux
Save less state in minimap_view
fd3a9d3 
The widget needs to compute horizontal and vertical scaling factors to
map between the displayed minimap (in pixel units) and the computed one
(essentially in tile units). It was computing them on resize events and
storing them, which was causing issues when switching maps. Compute them
when they are needed instead, it's just two float divisions.

Also remove a bunch of unused variables from the class and don't try to
move() it when shown (it's in a layout).

Closes longturn#1657.
@lmoureaux lmoureaux mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.1-stable
Development

Successfully merging a pull request may close this issue.

Save less state in minimap_view lmoureaux/freeciv21
3 participants
@lmoureaux @jwrober @Mu-00