Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial popups are titled "Popup Request" #1554

Closed
lmoureaux opened this issue Dec 4, 2022 · 0 comments · Fixed by #1569
Closed

Tutorial popups are titled "Popup Request" #1554

lmoureaux opened this issue Dec 4, 2022 · 0 comments · Fixed by #1569
Assignees
@jwrober
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.0-stable

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

The title of the tutorial popups is "Popup Request". This is meaningless for the user.

To Reproduce
Steps to reproduce the behavior:

  1. Start the tutorial
  2. Look at the first popup

Expected behavior
The title is at least somewhat meaningful. "Information"?

Screenshots
image

Platform and version (please complete the following information):

  • OS: any
  • Freeciv21 version: master as of 04.12.2022
  • Ruleset/Longturn game (if applicable): tutorial scenario

Additional context
climisc.cpp:916
@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface labels Dec 4, 2022
@lmoureaux lmoureaux added this to the v3.0-stable milestone Dec 4, 2022
jwrober added a commit to jwrober/freeciv21 that referenced this issue Dec 8, 2022
@jwrober
Change popup request to message for Lua notify.event() messages
bd4fef9 
Closes longturn#1554
@jwrober jwrober mentioned this issue Dec 8, 2022
Merged
jwrober added a commit that referenced this issue Dec 8, 2022
@jwrober
Change popup request to message for Lua notify.event() messages
af121a6 
Closes #1554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwrober jwrober

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.0-stable
Development

Successfully merging a pull request may close this issue.

Tutorial updates jwrober/freeciv21
2 participants
@lmoureaux @jwrober