Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going from Observe to Take loses buttons on top bar #1289

Closed
jwrober opened this issue Aug 16, 2022 · 2 comments · Fixed by #1668
Closed

Going from Observe to Take loses buttons on top bar #1289

jwrober opened this issue Aug 16, 2022 · 2 comments · Fixed by #1668
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone

Comments

@jwrober
Copy link
Collaborator

jwrober commented Aug 16, 2022

Describe the bug
If you open a single player game and do a global observe, you correctly lose access to some buttons on the top bar such as research, economy and tax rates. If you observe

To Reproduce
Steps to reproduce the behavior:

  1. Open a single player game
  2. In the chat line do an /observe
  3. Notice that Research, Economy and Tax Rates disappear -- good
  4. In the chat line do an /observe <player>
  5. Notice that you get back Tax Rates, but not Research or Economy -- bad
  6. In the chat line do a /take <player>
  7. Notice that you don't get back Research or Economy -- bad

The same thing happens if you go from global observe back to /take. If I do an /observe <player> it works as expected I keep all the buttons on the top bar. So it is something with global observe.

Expected behavior
We don't lose buttons into cyberspace.

Screenshots
I didn't capture any. You can see it for your self pretty easily.

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: Master at 68b5063
  • Ruleset/Longturn game (if applicable): Classic, but not sure its relevant

Additional context
I found it while playing around and testing PR #1287

@jwrober jwrober added bug Something isn't working gui This issue requires changes to the user interface labels Aug 16, 2022
@lmoureaux
Copy link
Contributor

Finally someone notices and files an issue 😅 (I had seen this before but forgot about it)

@lmoureaux lmoureaux added this to the Now milestone Aug 17, 2022
@lmoureaux lmoureaux modified the milestones: Now, v3.0-stable Nov 27, 2022
@jwrober jwrober modified the milestones: v3.0-stable, v3.1-stable Dec 12, 2022
@jwrober
Copy link
Collaborator Author

jwrober commented Dec 28, 2022

The same thing happens between /take and does not have to involve /observe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants