Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image sprite errors #1185

Closed
jwrober opened this issue Aug 2, 2022 · 0 comments · Fixed by #1217
Closed

Image sprite errors #1185

jwrober opened this issue Aug 2, 2022 · 0 comments · Fixed by #1217
Labels
bug Something isn't working Untriaged This issue or PR needs triaging

Comments

@jwrober
Copy link
Collaborator

jwrober commented Aug 2, 2022

Describe the bug
Under unknown circumstances the client produces errors in image sprites during combat.

To Reproduce
Steps to reproduce the behavior:

  1. Run as ASan autogame
  2. Autoconnect to the game and use global observe
  3. Let the game progress until the AI start to fight each other
  4. See error

Expected behavior
No sprite errors

Screenshots
image
image

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: Discovered while testing at this commit ab1a4cd
  • Ruleset/Longturn game (if applicable): None

Additional context
None
@jwrober jwrober added bug Something isn't working Untriaged This issue or PR needs triaging labels Aug 2, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 8, 2022
@lmoureaux
Initialize defender pixmap contents in hud_unit_combat
20ca714 
Otherwise it was showing garbage.

Closes longturn#1185.
@lmoureaux lmoureaux mentioned this issue Aug 8, 2022
Merged
jwrober pushed a commit that referenced this issue Aug 8, 2022
@lmoureaux @jwrober
Initialize defender pixmap contents in hud_unit_combat
ae8d8ef 
Otherwise it was showing garbage.

Closes #1185.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Untriaged This issue or PR needs triaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize defender pixmap contents in hud_unit_combat lmoureaux/freeciv21
1 participant
@jwrober