Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct end_turn() statistics #1075

Closed
psampathkumar opened this issue Jun 28, 2022 · 1 comment · Fixed by #1134
Closed

Correct end_turn() statistics #1075

psampathkumar opened this issue Jun 28, 2022 · 1 comment · Fixed by #1134
Assignees
@psampathkumar
Labels
bug Something isn't working port-from-freeciv This was implemented in Freeciv server This issue requires changes to the server

Comments

@psampathkumar
Copy link
Contributor

psampathkumar commented Jun 28, 2022 •
edited
Loading

Describe the bug
The calculated stats are not per-player as one would assume from the player name and other player-specific ones. Those stats are zeroed only before iterating the players, not for each player, so they accumulate over players iterated.

To Reproduce
Steps to reproduce the behavior:

  1. End turn
  2. See debug info

Expected behavior
You see per player stats

Screenshots
If applicable, add screenshots to help explain your problem.

Platform and version (please complete the following information):
master

Additional context
Port: freeciv/freeciv@d3d1a96
@psampathkumar psampathkumar added bug Something isn't working server This issue requires changes to the server port-from-freeciv This was implemented in Freeciv labels Jun 28, 2022
@lmoureaux
Copy link
Contributor

OSDN https://osdn.net/projects/freeciv/ticket/44879

@psampathkumar psampathkumar self-assigned this Jun 28, 2022
psampathkumar added a commit to psampathkumar/freeciv21 that referenced this issue Jul 14, 2022
@psampathkumar
Correct endturn statistics
838054f 
Ported from: freeciv/freeciv@d3d1a96
Fixes longturn#1075
@psampathkumar psampathkumar mentioned this issue Jul 14, 2022
Merged
lmoureaux pushed a commit that referenced this issue Jul 14, 2022
@psampathkumar @lmoureaux
Correct endturn statistics
0261129 
Ported from: freeciv/freeciv@d3d1a96
Fixes #1075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psampathkumar psampathkumar

Labels
bug Something isn't working port-from-freeciv This was implemented in Freeciv server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct endturn statistics psampathkumar/freeciv21
2 participants
@lmoureaux @psampathkumar