Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still leaking IP addresses #1069

Closed
lmoureaux opened this issue Jun 26, 2022 · 0 comments · Fixed by #1135
Closed

Still leaking IP addresses #1069

lmoureaux opened this issue Jun 26, 2022 · 0 comments · Fixed by #1135
Labels
bug Something isn't working server This issue requires changes to the server

Comments

@lmoureaux
Copy link
Contributor

lmoureaux commented Jun 26, 2022 •
edited
Loading

Describe the bug

The server still sends around the IP of connecting players in the Lost connection: xx from yy (network exception) (player God).

To Reproduce
Steps to reproduce the behavior:

  1. Run a network game
  2. Connect and disconnect
  3. See your IP being sent around by the server
  4. Rage about GDPR

Expected behavior

No personal info is leaked (but it's retained for logs)

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.0-beta.2
  • Ruleset/Longturn game (if applicable): LT73Avi
@lmoureaux lmoureaux added bug Something isn't working server This issue requires changes to the server labels Jun 26, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jul 14, 2022
@lmoureaux
Don't send out player IP adresses on disconnect
cfd53ad 
Closes longturn#1069.
@lmoureaux lmoureaux mentioned this issue Jul 14, 2022
Merged
lmoureaux added a commit that referenced this issue Jul 15, 2022
@lmoureaux
Don't send out player IP adresses on disconnect
9f2d41d 
Closes #1069.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IP leak from server lmoureaux/freeciv21
1 participant
@lmoureaux