Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the Blaze rendering engine. Also added a more flexible... #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pavlovich
Copy link
Contributor

... bootstrapping mechanism. Default behavior is the same as the original (bootstrapping 'ngMeteor' on the document element).

Review on Reviewable

…ble bootstrapping mechanism. Default behavior is the same as the original (bootstrapping 'ngMeteor' on the document element).

<ANY ng-template="foo"></ANY>

<!--Add the ng-controller attribute if you want to load a controller at the same time.-->
<ANY ng-template="foo" ng-controller="fooCtrl"></ANY>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need this since users only will render templates they identify with the ng-template directive. Templates are no longer pre-rendered and cached. This provides for rendering templates via meteor spacebars first and then rendering that output using angular's compile/link functionality.

Pre-rendering with render() and then caching the result was not very flexible in any case if the template was not 'static'. If you needed to generate the template contents, for example, using meteor's rendering engine, and then feed that result into the angular compile/link processor, then using the pre-rendered HTML from the templateCache would not have been helpful.

…rom page to page. Temporary 'partial fix' until memory leak issue can be solved.
…red through iron-router were overridden and lost when angular compile/digest cycle was incorporated.

This fix caches any registered 'rendered' callback and reapplies it after the angular compile/digest cycle is completed and then re-registers that callback on the template.
@Urigo
Copy link

Urigo commented Aug 27, 2014

@pavlovich We are a dev team that took on ourselves to support ngMeteor on this fork:
https://github.com/Urigo/ngMeteor/tree/v0.2
We already added support for Meteor 0.8.3 and got more pull requests from people.
If you think your pull request is relevant to our new version we would love to test it and merge it into our version.
In a week we will merge the 0.2 branch into master.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants