TypeScript SQLite support #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transaction kinda support. have to rewrite this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds SQLite support for the API.
Currently, only supported via the
DB_CONNECTION_STRINGenv variable. If set tosqlite:///, it uses an in-memory instance, if set tosqlite:///{filename}, it uses the file to store the data.It uses the better-sqlite library which claims to be better than the combo of sqlite and sqlite3.
The downside is that the better-sqlite library doesn't support an asynchronous API for many reasons so had to refactor a bunch of the code to support a synchronous API as well as asynchronous API for both reads and writes.
In scenarios where the difference doesn't matter, we still use a public facing asynchronous API and just make a synchronous call. However, for transactions, can't do that so that's where the API changes are seen the most.
SQLite seems to support both query formats:
SELECT * FROM tbl WHERE id = $1andSELECT * FROM tbl WHERE id = ?we use the latter exclusively just so that we're slightly closer to MySQL support. No current plans to.