[BasicUI] Enhance the description of the "Inline SVG" setting (openha…

…b#2247) In order to explain the default value. Related to openhab#2240 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo · Jan 2, 2024 · b6aeaa5 · b6aeaa5
1 parent 898b519
commit b6aeaa5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/bundles/org.openhab.ui.basic/src/main/resources/OH-INF/config/config.xml b/bundles/org.openhab.ui.basic/src/main/resources/OH-INF/config/config.xml
@@ -32,7 +32,9 @@
 				the case
 				where the SVG icon sets "currentColor" as the fill color. Note that this will work with custom SVG icons but not
 				with all the packaged icons from the classic iconset since they are defined with a hard-coded color palette. This
-				feature is disabled by default.</description>
+				feature is disabled by default due to additional non-standard processing required leading to a larger page size and
+				because it is unnecessary if you only use Material/framework7/iconify icons or openHAB icons from the classic icon
+				set.</description>
 			<options>
 				<option value="true">Enable</option>
 				<option value="false">Disable</option>

diff --git a/bundles/org.openhab.ui.basic/src/main/resources/OH-INF/i18n/basic.properties b/bundles/org.openhab.ui.basic/src/main/resources/OH-INF/i18n/basic.properties
@@ -17,7 +17,7 @@ ui.config.basic.enableIcons.description = Defines whether UI renders icons for t
 ui.config.basic.enableIcons.option.true = Enable
 ui.config.basic.enableIcons.option.false = Disable
 ui.config.basic.inlineSvg.label = Inline SVG
-ui.config.basic.inlineSvg.description = If enabled, any SVG icon provided by the openHAB icon server will automatically be converted to an inline SVG in the WEB page, allowing control of its color with the sitemap widget property "iconcolor" in the case where the SVG icon sets "currentColor" as the fill color. Note that this will work with custom SVG icons but not with all the packaged icons from the classic iconset since they are defined with a hard-coded color palette. This feature is disabled by default.
+ui.config.basic.inlineSvg.description = If enabled, any SVG icon provided by the openHAB icon server will automatically be converted to an inline SVG in the WEB page, allowing control of its color with the sitemap widget property "iconcolor" in the case where the SVG icon sets "currentColor" as the fill color. Note that this will work with custom SVG icons but not with all the packaged icons from the classic iconset since they are defined with a hard-coded color palette. This feature is disabled by default due to additional non-standard processing required leading to a larger page size and because it is unnecessary if you only use Material/framework7/iconify icons or openHAB icons from the classic icon set.
 ui.config.basic.inlineSvg.option.true = Enable
 ui.config.basic.inlineSvg.option.false = Disable
 ui.config.basic.nbColumns.label = Number of Columns